Tight garments on soldiers, clothing no good (8)
I believe the answer is:
leggings
'tight garments' is the definition.
'on soldiers clothing no good' is the wordplay.
'on' becomes 'leg' (cricket term, fielding positions).
'soldiers' becomes 'gis' (GI is an informal term for a US soldier).
'clothing' indicates putting letters inside (some letters cover up or clothe others).
'no good' becomes 'ng' (abbreviation for no and good).
'gis' placed around 'ng' is 'gings'.
'leg'+'gings'='LEGGINGS'
(Other definitions for leggings that I've seen before include "Garments for lower limbs" , "Ski-pants without stirrups" , "Close-fitting trousers" .)